test: add unit tests for 5 security/logic-critical modules (batch 4) - #193
Merged
Conversation
- gateway/pairing.py: rate limiting, lockout, code expiry, approval flow (28 tests) - tools/skill_manager_tool.py: validation, path traversal prevention, CRUD (46 tests) - tools/skills_tool.py: frontmatter/tag parsing, skill discovery, view chain (34 tests) - agent/auxiliary_client.py: auth reading, API key resolution, param branching (16 tests) - honcho_integration/session.py: session dataclass, ID sanitization, transcript format (20 tests)
# Conflicts: # tests/agent/test_auxiliary_client.py
Contributor
|
Merged in commit b336980. All 128 new tests pass, full suite at 1480. Thanks for the thorough coverage on security-critical modules! 🙏 Note: the PR description mentions 16 auxiliary_client.py tests but they don't appear in the diff — might have been accidentally left out of the branch. No blocker, the 128 tests that are here are solid. |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…al modules (batch 4) Authored by 0xbyt4. 144 new tests covering gateway/pairing.py, tools/skill_manager_tool.py, tools/skills_tool.py, honcho_integration/session.py, and agent/auxiliary_client.py.
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…al modules (batch 4) Authored by 0xbyt4. 144 new tests covering gateway/pairing.py, tools/skill_manager_tool.py, tools/skills_tool.py, honcho_integration/session.py, and agent/auxiliary_client.py.
nicezic
pushed a commit
to nicezic/hermes-agent
that referenced
this pull request
Aug 26, 2026
run_conversation() only injects /steer into a *following* tool result. A steer that lands after the final tool batch — or during a text-only turn — comes back as result["pending_steer"] for the caller to re-deliver. cli.py consumes it, but the tui_gateway turn-runner (every desktop/TUI/Dashboard chat) never read it, so the leftover steer was silently dropped. This is acute on the desktop, whose default busy-input mode is "steer": users reported (NousResearch#193) that a steer sent mid-task "等到任务执行完也没插入进去". Fix mirrors the existing goal_followup chain: capture result["pending_steer"] and, after the finally releases session["running"], fire a nested _run_prompt_submit with the steered text. Guarded by the running flag so a racing real prompt wins; runs before goal continuation since it's explicit user input. No extra message.start (the nested call emits its own). Tests: tests/tui_gateway/test_pending_steer_followup.py. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
144 new tests, zero source code changes.