Skip to content

fix(doctor): use get_env_value for API keys and base URLs instead of os.getenv #18989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shellybotmoyer wants to merge 1 commit into from
Closed

fix(doctor): use get_env_value for API keys and base URLs instead of os.getenv #18989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions hermes_cli/doctor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,7 +995,8 @@ def run_doctor(args):
print()
print(color("◆ API Connectivity", Colors.CYAN, Colors.BOLD))

openrouter_key = os.getenv("OPENROUTER_API_KEY")
from hermes_cli.config import get_env_value as _get_env_value
openrouter_key = _get_env_value("OPENROUTER_API_KEY") or os.getenv("OPENROUTER_API_KEY")
if openrouter_key:
print(" Checking OpenRouter API...", end="", flush=True)
try:
Expand Down Expand Up @@ -1108,7 +1109,7 @@ def run_doctor(args):
for _pname, _env_vars, _default_url, _base_env, _supports_health_check in _apikey_providers:
_key = ""
for _ev in _env_vars:
_key = os.getenv(_ev, "")
_key = _get_env_value(_ev) or os.getenv(_ev, "")
if _key:
break
if _key:
Expand All @@ -1120,7 +1121,7 @@ def run_doctor(args):
print(f" Checking {_pname} API...", end="", flush=True)
try:
import httpx
_base = os.getenv(_base_env, "") if _base_env else ""
_base = (_get_env_value(_base_env) or os.getenv(_base_env, "")) if _base_env else ""
# Auto-detect Kimi Code keys (sk-kimi-) → api.kimi.com/coding/v1
# (OpenAI-compat surface, which exposes /models for health check).
if not _base and _key.startswith("sk-kimi-"):
Expand Down