Skip to content

fix(kanban): anchor board to default Hermes root, not active profile #18985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gosuj wants to merge 1 commit into from
Closed

fix(kanban): anchor board to default Hermes root, not active profile #18985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions hermes_cli/kanban_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
"""SQLite-backed Kanban board for multi-profile collaboration.

The board lives at ``$HERMES_HOME/kanban.db`` (profile-agnostic on purpose:
multiple profiles on the same machine all see the same board, which IS the
coordination primitive).
The board lives at the *default* Hermes root (``~/.hermes/kanban.db`` in
standard installs, ``$HERMES_HOME/kanban.db`` in Docker / custom roots) —
profile-agnostic on purpose: multiple profiles on the same machine all see
the same board, which IS the coordination primitive. The path is resolved
via ``get_default_hermes_root()``, NOT ``get_hermes_home()``, so that a
worker running under ``hermes -p <name>`` (HERMES_HOME pointed at
``profiles/<name>``) still reaches the shared host-level board instead of a
private per-profile DB. See issue #18442.

Schema is intentionally small: tasks, task_links, task_comments,
task_events. The ``workspace_kind`` field decouples coordination from git
Expand Down Expand Up @@ -62,15 +67,26 @@
# ---------------------------------------------------------------------------

def kanban_db_path() -> Path:
"""Return the path to ``kanban.db`` inside the active HERMES_HOME."""
from hermes_constants import get_hermes_home
return get_hermes_home() / "kanban.db"
"""Return the path to the shared host-level ``kanban.db``.

Resolved against the *default* Hermes root rather than the active
profile's HERMES_HOME, so that a worker spawned under
``hermes -p <name>`` reaches the same board as the dispatcher and the
other profiles on the host. See issue #18442.
"""
from hermes_constants import get_default_hermes_root
return get_default_hermes_root() / "kanban.db"


def workspaces_root() -> Path:
"""Return the directory under which ``scratch`` workspaces are created."""
from hermes_constants import get_hermes_home
return get_hermes_home() / "kanban" / "workspaces"
"""Return the directory under which ``scratch`` workspaces are created.

Anchored at the default Hermes root for the same reason as
:func:`kanban_db_path` -- workspace paths are absolute and shared across
profiles, so they must not be created under a profile-private root.
"""
from hermes_constants import get_default_hermes_root
return get_default_hermes_root() / "kanban" / "workspaces"


# ---------------------------------------------------------------------------
Expand Down