Skip to content

fix(context): pass custom_providers in aux compression and fallback paths #18877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rkt2spc wants to merge 1 commit into from
Closed

fix(context): pass custom_providers in aux compression and fallback paths #18877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions run_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2652,12 +2652,29 @@ def _check_compression_model_feasibility(self) -> None:
aux_base_url = str(getattr(client, "base_url", ""))
aux_api_key = str(getattr(client, "api_key", ""))

# Load custom_providers so per-model context_length overrides
# are honored for the compression model — mirrors the
# switch_model() path. Without this, the auxiliary probe skips
# step 0b in get_model_context_length and falls back to the
# 256K default, even when the user set
# custom_providers[].models[].context_length in config.yaml.
_aux_custom_providers = None
try:
from hermes_cli.config import (
load_config,
get_compatible_custom_providers,
)
_aux_custom_providers = get_compatible_custom_providers(load_config())
except Exception:
_aux_custom_providers = None

aux_context = get_model_context_length(
aux_model,
base_url=aux_base_url,
api_key=aux_api_key,
config_context_length=getattr(self, "_aux_compression_context_length_config", None),
provider=getattr(self, "provider", ""),
custom_providers=_aux_custom_providers,
)

# Hard floor: the auxiliary compression model must have at least
Expand Down Expand Up @@ -7632,10 +7649,24 @@ def _try_activate_fallback(self, reason: "FailoverReason | None" = None) -> bool
# the fallback activation drops to 128K even when config says 204800.
if hasattr(self, 'context_compressor') and self.context_compressor:
from agent.model_metadata import get_model_context_length
# Pass custom_providers so per-model context_length overrides
# apply to the fallback model too — same fix as the aux
# compression path; otherwise a custom-provider fallback
# falls back to the 256K default.
_fb_custom_providers = None
try:
from hermes_cli.config import (
load_config,
get_compatible_custom_providers,
)
_fb_custom_providers = get_compatible_custom_providers(load_config())
except Exception:
_fb_custom_providers = None
fb_context_length = get_model_context_length(
self.model, base_url=self.base_url,
api_key=self.api_key, provider=self.provider,
config_context_length=getattr(self, "_config_context_length", None),
custom_providers=_fb_custom_providers,
)
self.context_compressor.update_model(
model=self.model,
Expand Down