Skip to content

fix(gateway): respect reply_in_thread=false for Slack progress messages #18859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
patp wants to merge 2 commits into from
Closed

fix(gateway): respect reply_in_thread=false for Slack progress messages #18859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
704bf3c
fix(gateway): respect reply_in_thread=false for Slack progress messages
patp May 2, 2026
712268b
fix(gateway): drop synthetic thread_id from progress messages
patp May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion gateway/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11961,7 +11961,36 @@ def progress_callback(event_type: str, tool_name: str = None, preview: str = Non
# normal DM/group message id as thread_id causes send failures
# - Other platforms should use explicit source.thread_id only
if source.platform == Platform.SLACK:
_progress_thread_id = source.thread_id or event_message_id
# The Slack adapter falls back to event_message_id so progress
# messages can be edited inside a thread. Honour
# platforms.slack.extra.reply_in_thread=false: if the user has
# opted out of threaded replies, don't synthesise a thread for
# progress messages either — the very first progress message
# would otherwise create a thread that all subsequent replies
# (including the final answer) would inherit.
slack_adapter = (self.adapters or {}).get(Platform.SLACK)
slack_reply_in_thread = True
if slack_adapter is not None:
slack_reply_in_thread = slack_adapter.config.extra.get(
"reply_in_thread", True
)
if slack_reply_in_thread:
_progress_thread_id = source.thread_id or event_message_id
else:
# The Slack adapter sets source.thread_id to the user's own
# message ts for top-level DMs (synthetic thread used for
# session keying). When reply_in_thread is false, treat that
# synthetic thread_id as "no thread" so progress messages
# stay at the channel/DM top level instead of starting a
# thread that subsequent messages would inherit.
if (
source.thread_id
and event_message_id
and source.thread_id == event_message_id
):
_progress_thread_id = None
else:
_progress_thread_id = source.thread_id
else:
_progress_thread_id = source.thread_id
_progress_metadata = {"thread_id": _progress_thread_id} if _progress_thread_id else None
Expand Down