Conversation
Collaborator
|
Thanks for the session-continuity work. Current
No release tag was identified for the relevant changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_reset.reset_suspendedto control whether stopped/interrupted gateway sessions are hard-resetresume_pendingso the next message continues with the existing transcriptWhy
The existing hard-suspend path was introduced to avoid unrecoverable stuck-session loops (#7536). Later restart-resume work added
resume_pendingfor interrupted restarts (#11852), but explicitsuspendedsessions still always force a fresh session. That is safe, but it can be too destructive for deployments that prefer continuity and explicit/reset.This PR keeps upstream default behavior unchanged (
reset_suspended: true) and adds an opt-in for deployments that want stopped/interrupted sessions to continue automatically.Validation
/home/juan/.hermes/hermes-agent/venv/bin/python -m pytest tests/gateway/test_config.py::TestSessionResetPolicy tests/gateway/test_restart_resume_pending.py::TestGetOrCreateResumePending tests/gateway/test_session_reset_notify.py::TestResetPolicyNotify -qRelated: #7536, #4493, #9850, #9934, #11852