Skip to content

fix(agent): remove hardcoded 30s timeout in title_generator - #18839

Closed
Elagizy wants to merge 1 commit into
NousResearch:mainfrom
Elagizy:fix/timeout-title
Closed

fix(agent): remove hardcoded 30s timeout in title_generator#18839
Elagizy wants to merge 1 commit into
NousResearch:mainfrom
Elagizy:fix/timeout-title

Conversation

@Elagizy

@Elagizy Elagizy commented May 2, 2026

Copy link
Copy Markdown

Problem

The generate_title() function in agent/title_generator.py hardcoded timeout=30.0, bypassing the configured auxiliary LLM timeout from config.yaml. This caused title generation to fail when using slow local models with cold start times exceeding 30 seconds (e.g., qwen3.6-27b at ~88s cold start).

Solution

Changed default to timeout=None so it falls through to the configured value, allowing users to tune the timeout for their model response time characteristics.

Changes

  • agent/title_generator.py: Changed timeout: float = 30.0timeout: float = None
  • Updated docstring to explain the behavior

The generate_title() function previously hardcoded timeout=30.0,
bypassing the configured auxiliary LLM timeout from config.yaml.
This caused title generation to fail when using slow local models
with cold start times exceeding 30 seconds (e.g. qwen3.6-27b at
~88s cold start).

Changed default to timeout=None so it falls through to the
configured value, allowing users to tune the timeout for their
model's response time characteristics.
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint labels May 2, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #18129 — same root cause: hardcoded 30s timeout in title_generator.py insufficient for slow local models. Previous attempt #18838 was already closed as duplicate.

@alt-glitch

Copy link
Copy Markdown
Collaborator

Likely duplicate of #18129 — same fix for hardcoded 30s timeout in title_generator.py.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused configuration-correctness fix. Closing as implemented on main; this is an automated hermes-sweeper review.

  • 5126902f1d77ccca0fb7b0f9c780d9b80e6a4fe2 (fix(title): honor configured auxiliary timeout) already changed agent/title_generator.py:54 to default timeout to None and forwards it at agent/title_generator.py:87.
  • agent/auxiliary_client.py:6054-6065 resolves a None timeout from auxiliary.{task}.timeout, so auxiliary.title_generation.timeout now controls this path.
  • tests/agent/test_title_generator.py:62-91 covers both config delegation and explicit-timeout override behavior.
  • This supersedes the duplicate-family discussion referencing fix(agent): make title generation timeout configurable via auxiliary.title_generation.timeout #18129.

@teknium1 teknium1 closed this Jul 12, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants