fix(agent): remove hardcoded 30s timeout in title_generator - #18839
Closed
Elagizy wants to merge 1 commit into
Closed
fix(agent): remove hardcoded 30s timeout in title_generator#18839Elagizy wants to merge 1 commit into
Elagizy wants to merge 1 commit into
Conversation
The generate_title() function previously hardcoded timeout=30.0, bypassing the configured auxiliary LLM timeout from config.yaml. This caused title generation to fail when using slow local models with cold start times exceeding 30 seconds (e.g. qwen3.6-27b at ~88s cold start). Changed default to timeout=None so it falls through to the configured value, allowing users to tune the timeout for their model's response time characteristics.
Collaborator
Collaborator
|
Likely duplicate of #18129 — same fix for hardcoded 30s timeout in title_generator.py. |
1 task
Contributor
|
Thanks for the focused configuration-correctness fix. Closing as implemented on main; this is an automated hermes-sweeper review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
generate_title()function inagent/title_generator.pyhardcodedtimeout=30.0, bypassing the configured auxiliary LLM timeout fromconfig.yaml. This caused title generation to fail when using slow local models with cold start times exceeding 30 seconds (e.g., qwen3.6-27b at ~88s cold start).Solution
Changed default to
timeout=Noneso it falls through to the configured value, allowing users to tune the timeout for their model response time characteristics.Changes
agent/title_generator.py: Changedtimeout: float = 30.0→timeout: float = None