feat: expose subagent tool activity as persistent CLI lines - #187
Closed
0xbyt4 wants to merge 1 commit into
Closed
Conversation
Previously subagent tool calls only updated the delegate spinner text, overwriting each other so the user only saw the last one. All child stdout was suppressed via redirect_stdout(devnull). Now each subagent tool call prints a persistent indented line: ┊ ↳ [sub-1] terminal "npm install" ┊ ↳ [sub-1] read_file "src/auth.py" Child stdout is no longer suppressed (quiet_mode=True already limits output to formatted tool lines). prompt_toolkit's patch_stdout handles thread-safe rendering. Closes NousResearch#169
Contributor
|
Sorry I implemnented this one: #186 |
timbeaulac
pushed a commit
to timbeaulac/hermes-agent
that referenced
this pull request
Jun 20, 2026
Refs revise-repeat/siva-os#187 Co-authored-by: siva-splicer[bot] <292605095+siva-splicer[bot]@users.noreply.github.com> Generated-By: hermes/2.0 (role: Splicer; model: gpt-5.5) Agent-Session: 20260620_030045_2e35e647 Task-Reference: NousResearch#187
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #169 -- subagent actions are now visible to the user during delegation.
Before: Subagent tool calls only updated the delegate spinner text, overwriting each other. The user saw only the last tool call and all child stdout was suppressed via
redirect_stdout(devnull).After: Each subagent tool call prints a persistent indented line below the spinner:
Changes (single file:
tools/delegate_tool.py)_child_progresscallback now prints persistent┊ ↳ [sub-N] tool "preview"lines instead of updating the spinner textredirect_stdout(devnull)wrapper -- child runs withquiet_mode=Truewhich already limits output to formatted tool linessys.stdout/sys.stderrsave/restore workaround (no longer needed without redirect)contextlib,io,sys)Why this is safe
quiet_mode=Trueon child agents already suppresses raw model output -- only cute tool messages are printedprompt_toolkit.patch_stdout(active in CLI) handles concurrent writes from background threads -- same pattern already used by batch mode completion lines (line 328)parent_progress_cb) is unchanged