Conversation
teknium1
left a comment
There was a problem hiding this comment.
Thanks for targeting the persisted Kimi pool case. The stale-entry premise remains valid on current main: hermes_cli/auth.py:1340-1345 returns stored entries unchanged, agent/credential_pool.py:2342-2355 rehydrates them, and hermes_cli/runtime_provider.py:409 uses the selected entry’s URL.
Problems
hermes_cli/auth.py:962overwrites every Kimi entry’s storedbase_url. Current runtime deliberately treats a non-default pool URL as explicit (hermes_cli/runtime_provider.py:476-485), so this would replace intentionally configured proxy/custom endpoints.- The current
read_credential_pool()has profile/global per-provider fallback semantics athermes_cli/auth.py:1301-1345; the proposed hunk predates that implementation and must be integrated with it.
Suggested changes
- Normalize only missing or known-stale default URLs, while preserving non-default stored URLs absent an explicit
KIMI_BASE_URLoverride. - Add a pool-to-runtime regression test, plus preservation coverage for a non-default pool URL.
Automated hermes-sweeper review.
| or item.get("api_key") | ||
| or "" | ||
| ).strip() | ||
| item["base_url"] = _resolve_kimi_base_url( |
There was a problem hiding this comment.
This rewrites every persisted Kimi endpoint, including a deliberate non-default proxy/custom URL. Current runtime treats non-default pool URLs as explicit (hermes_cli/runtime_provider.py:476-485); please limit rewriting to missing or known-stale default URLs, while retaining explicit endpoint values unless KIMI_BASE_URL is set.
|
@LeonSGP43 — thanks for starting the initial work on this! Following up on the sweeper's keep_open review, the requested changes were: (1) preserving custom/non-default stored URLs, (2) integrating with the current profile/global fallback semantics in Since this PR hasn't seen updates since May (and the |
Summary
Fixes #5908
Verification