You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the focused Slack log-noise fix. Current main still logs each users.conversations non-OK response at gateway/channel_directory.py:243 and each workspace-client exception at gateway/channel_directory.py:264; gateway housekeeping refreshes the directory every five minutes (gateway/run.py:20123-20133). The PR routes both paths through the same team/error-keyed monotonic throttle and adds regression coverage for repeated non-OK workspace responses.
No correctness problems were verified in the proposed change. This is an automated hermes-sweeper review.
Merged via #70192 — your commit was cherry-picked/reapplied onto current main with your authorship preserved in git history: your channel-directory warning throttle was cherry-picked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/gatewayGateway runner, session dispatch, deliveryP3Low — cosmetic, nice to haveplatform/slackSlack app adaptersweeper:blast-containedSweeper blast radius: contained — one narrow path / opt-in / few userstype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18485
Signal Deck card: ops-ops-channel-directory-failed-to-list-slack-channels-for-team-the-request-to-the-slack-api-
Tests