fix(gateway): deliver MEDIA files for queued follow-up responses

[vnhwd]

Summary

When multiple /queue items are chained in a single session, only the last item's MEDIA files (PDFs, images, etc.) were delivered. Preceding items showed raw MEDIA:/path tags because the queue drain path called adapter.send() without first extracting and delivering media attachments.

Fix

Call adapter.extract_media() before adapter.send() in the queue follow-up path (gateway/run.py), mirroring the normal delivery path in gateway/platforms/base.py L2724. Each extracted file is then delivered via adapter.send_document().

+ media_files, first_response = adapter.extract_media(first_response)
  await adapter.send(source.chat_id, first_response, ...)
+ for media_path, _is_voice in media_files:
+     await adapter.send_document(chat_id=source.chat_id, file_path=media_path, ...)

Testing

• Existing test suites pass: 3385 passed, 10 skipped
  • tests/gateway/test_pending_drain_no_recursion.py — 5/5 ✓
  • tests/gateway/test_tts_media_routing.py — 29/29 ✓
  • tests/gateway/test_send_image_file.py — all ✓

Closes #18539

[liuhao1024]

The media extraction pipeline for queued follow-ups is correct and well-tested. One production-reliability issue though:

Inconsistent error handling in delivery loops. The image and local-file delivery loops use bare except Exception: pass, silently swallowing all failures:

# Deliver extracted images
for image_url, alt_text in (images or []):
    try:
        await adapter.send_image(...)
    except Exception:
        pass  # ← silent
# Deliver extracted local files
for local_path in (local_files or []):
    try:
        await adapter.send_document(...)
    except Exception:
        pass  # ← silent

But the media-file loop correctly logs:

except Exception as media_e:
    logger.warning("Failed to deliver queue media %s: %s", media_path, media_e)

This means image and file delivery failures are completely invisible in production logs. If an adapter's send_image raises (bad URL, expired token, platform rate-limit), the user silently loses the image with no trace.

Suggestion: Match the media-file pattern for the other two loops:

except Exception as img_e:
    logger.warning("Failed to deliver queue image %s: %s", image_url, img_e)

except Exception as doc_e:
    logger.warning("Failed to deliver queue file %s: %s", local_path, doc_e)

[vnhwd]

Thanks for catching the inconsistency — pushed a fix in e1bb21d. All three delivery loops (images, local files, media files) now use logger.warning() with consistent formatting. Full gateway test suite passes (2992 passed, the 1 failure is a pre-existing unrelated Discord test).

[teknium1]

Thanks for identifying a real queued-delivery gap. Current main still sends the raw queued response at gateway/run.py:19724-19728, so this needs a fix; however, this revision needs rework before salvage.

Problems

• The added queue pipeline bypasses the media-path allowlist now required by the normal and post-stream paths (gateway/platforms/base.py:4903-4924, gateway/run.py:13121-13132). Commit 41d2c758c39a20c1213b65253a3459c1f96759a3 established that model-emitted attachment paths must be filtered before upload.
• The proposed loop sends all extracted files as documents and discards _is_voice, unlike the current type-aware routing for images, voice, video, and documents (gateway/platforms/base.py:5050-5114).
• The new tests replay copied extraction logic rather than executing the queued raw-send branch at gateway/run.py:19724, so they would not prove the integration point is fixed.

Suggested changes

• Rework the current queued branch to preserve cleaned-text delivery while sharing the existing validation and native-routing behavior in gateway/run.py:13097-13216.
• Add a regression test through the actual queued-follow-up path, including safe-path filtering and attachment routing.

Automated hermes-sweeper review.

[teknium1]

Closing as superseded: #82162 (salvage of #71031) landed on main and fixes queued follow-up MEDIA delivery for both branches — the non-streamed fallback that leaked literal MEDIA: text (this PR's target) and the streamed branch that silently dropped attachments — while routing through the existing extract_media + _deliver_media_from_response machinery so image batching, voice routing, path-security filtering, and the explicit-only policy are preserved. Thanks for attacking this bug; your report and approach helped establish the fix's requirements.