toolset check exception handling + empty choices in context compressor - #185
Closed
aksamlan wants to merge 3 commits into
Closed
toolset check exception handling + empty choices in context compressor#185aksamlan wants to merge 3 commits into
aksamlan wants to merge 3 commits into
Conversation
Add test for handling toolset availability when check_fn raises an error.
jjaavvin-web
added a commit
to jjaavvin-web/hermes-agent
that referenced
this pull request
Jun 23, 2026
… console errors Root cause was NOT node count: React NousResearch#185 (max update depth) infinite loop — the ForceGraph2D canvas height drove the container height -> ResizeObserver -> setSize -> re-render -> resize -> forever (plus an unguarded onZoom->setZoom). The graph re-rendered perpetually, never cooled. Fixes: (1) ForceGraph2D taken out of layout flow (absolute inset-0) so the canvas no longer drives container height -> ResizeObserver loop broken (container/canvas stable 695x620); (2) guard onZoom setZoom against <0.01 deltas; (3) flip HUD to 'cooled' once the engine pauses (onEngineStop never fires with pinned hubs). loki12 also gated link particles to selection-only + cut decorative nodes (field 2450->600, halo cap 1350->160). Verified live via Playwright: idle 38fps->61fps, worst frame 682ms->18ms, 0 frames>50ms, console errors 21->1 (benign auth 401), HUD settling->cooled, organism density preserved. Co-Authored-By: Hermes loki-lane <gpt-5.5@hermes.local> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EXvD2Fy24DmnmPSfLgNamn
1 task
tanmayvarun
added a commit
to tanmayvarun/hermes-agent
that referenced
this pull request
Aug 14, 2026
…eway path Checkpoint work before the MemorySystem / entity-resolution pass: ChargePe-shaped invariants and task facts, prompt-as-task footer, setup blockers, WhatsApp gateway pairing, and desktop React NousResearch#185 footer fix; prune stale live eval/experiment artifacts. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes:
Registry: When a toolset's check_fn raises (e.g. missing API key, import error), is_toolset_available() was propagating the exception and CLI/banner/doctor could crash. Now we catch it, log at debug, and return False so the toolset is just marked unavailable.
Context compressor: If the summary API returns empty choices or content is None, we were hitting IndexError/AttributeError before the outer except. Added explicit checks and use the same fallback summary in those cases.
Added a test for the registry behavior.