fix(auth): make provider config writes atomic - #18217
Merged
Merged
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #16504 onto current main (cherry-picked clean, authorship preserved via rebase-merge).
Summary
Switches the two remaining raw-YAML
config.yamlwrites inhermes_cli/auth.pyto the establishedatomic_yaml_writehelper. An interrupted provider-switch or logout can no longer leaveconfig.yamlpartially written.Changes
hermes_cli/auth.py:_update_config_for_providerand_reset_config_providernow callatomic_yaml_write(2 lines).Validation
write_text(yaml.safe_dump(...))sites remain outside of tests.Credit: @Yukipukii1 (commit authorship preserved).
Closes #16504.