test(skill_utils): regression tests for non-dict metadata in extract_skill_conditions - #18213
Merged
Merged
Conversation
…act_skill_conditions The fix for this bug (isinstance guard) was merged via commit 3ff9e01, but test coverage was not included. Adding 4 tests: - dict metadata with hermes keys (normal case) - string metadata (bug case — previously caused AttributeError) - None metadata - missing metadata key
4 tasks
alt-glitch
added
type/test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locks in the existing
isinstance(metadata, dict)guard inextract_skill_conditions()so a future refactor cannot silently regress it back tofrontmatter.get("metadata") or {}— which crashes on skills whose frontmatter hasmetadata:as a plain string or any other non-dict value.Coverage added
metadataas a valid nested dict withhermes:keysmetadataas a string (malformed YAML) — the regression casemetadataasNonemetadatakey absentValidation
scripts/run_tests.sh tests/agent/test_skill_utils.py— 4 passed.Mutation-verified: removing the
isinstance(metadata, dict)guard causestest_metadata_as_string_does_not_crashto fail withAttributeError: 'str' object has no attribute 'get'.Salvaged from #16688 by @sprmn24. The original PR bundled this with two unrelated changes; splitting into separate PRs for clean review.