fix(curator): preserve last_report_path in state - #18169
Merged
Merged
Conversation
11 tasks
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #18058 by @Yukipukii1 onto current main.
Summary
hermes curator statusnow shows the last report path instead of always showing none. Root cause: curator wrotelast_report_pathinto state butload_state()only preserved keys present in_default_state(), silently dropping it on the next read.Changes
agent/curator.py: addlast_report_pathto_default_state()tests/agent/test_curator.py: regression test for save → load round-tripValidation
scripts/run_tests.sh tests/agent/test_curator.py→ 39 passedlast_report_pathset → load → field preserved (previously dropped)Authored by @Yukipukii1 (commit authorship preserved). Closes #18058.