fix(curator): respect curator.auxiliary config for review model - #18039
fix(curator): respect curator.auxiliary config for review model#18039apcjoaofilho wants to merge 1 commit into
Conversation
The _run_llm_review function in agent/curator.py was always resolving the model/provider from cfg['model'], ignoring any curator.auxiliary settings in config.yaml. This caused the curator to always run on the user's main (expensive) model even when curator.auxiliary was configured to use a cheaper auxiliary model. Changes: - Read curator.auxiliary.provider and curator.auxiliary.model first - Fall back to cfg['model'] only when curator.auxiliary is unset - Preserves backward compatibility (existing configs without curator.auxiliary continue to work exactly as before) Fixes NousResearch#17572
|
Likely duplicate of #17868 (merged) — curator.auxiliary config resolution was already fixed and unified under the auxiliary.curator slot with CLI picker and deprecation-compatible fallback. |
1 similar comment
|
Likely duplicate of #17868 (merged) — curator.auxiliary config resolution was already fixed and unified under the auxiliary.curator slot with CLI picker and deprecation-compatible fallback. |
|
Likely duplicate of #17868 (merged). |
1 similar comment
|
Likely duplicate of #17868 (merged). |
|
Thanks for the fix @apcjoaofilho — unfortunately this was already resolved by PR #17868 ("fix(curator): unify under auxiliary.curator"), which landed a few weeks before your submission. Current
So the behavior you wanted — |
Problem
The
_run_llm_reviewfunction inagent/curator.pywas always resolving the model/provider fromcfg['model'], ignoring anycurator.auxiliarysettings in config.yaml.This caused the curator to always run on the user's main (often expensive) model even when
curator.auxiliarywas explicitly configured to use a cheaper auxiliary model.Root Cause
Introduced by commit
fa9383d("feat(curator): umbrella-first prompt, inherit parent config"). The fix for an OpenRouter empty-credentials path replaced thecurator.auxiliaryread entirely instead of falling back to it.Changes
curator.auxiliary.providerandcurator.auxiliary.modelfirstcfg['model']only whencurator.auxiliaryis unsetcurator.auxiliarycontinue to work exactly as beforeVerification
python3 -m py_compile agent/curator.py)curator.auxiliaryconfigured → curator now uses the configured auxiliary modelcurator.auxiliary→ curator falls back to main model (previous behavior)Fixes #17572