feat(gateway): restart manual profile gateways after update - #17982
Closed
quocanh261997 wants to merge 1 commit into
Closed
feat(gateway): restart manual profile gateways after update#17982quocanh261997 wants to merge 1 commit into
quocanh261997 wants to merge 1 commit into
Conversation
quocanh261997
marked this pull request as ready for review
April 30, 2026 14:50
Contributor
|
Merged via PR #18178 — your commit was cherry-picked onto current main with your authorship preserved in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
gateway.pidfile.hermes update, relaunch profile-mapped manual gateways after terminating the old process.Why
hermes updatealready restarts service-managed gateways through systemd or launchd, including profile units. Manual profile gateways were only stopped, leaving users to runhermes -p <profile> gateway runor a profile wrapper restart by hand. This made multi-profile updates cumbersome and easy to leave half-refreshed.How to test
Result:
42 passed.Platforms tested
Cross-platform impact
This touches process management. The change keeps the existing systemd and launchd service paths intact, and only adds a relaunch path for manual gateway processes that can be mapped through profile PID files. Unmapped manual processes keep the existing manual restart guidance.