context_compressor: preserve absolute threshold override across model switches - #17883
Closed
BeliefanX wants to merge 1 commit into
Closed
context_compressor: preserve absolute threshold override across model switches#17883BeliefanX wants to merge 1 commit into
BeliefanX wants to merge 1 commit into
Conversation
BeliefanX
force-pushed
the
beliefanx/context-compression-threshold-tokens
branch
4 times, most recently
from
May 6, 2026 08:27
92203a0 to
f7ae224
Compare
Contributor
Author
|
Refreshed this PR onto current Current status after refresh:
I ran the relevant focused tests locally for this PR before force-pushing the refreshed branch. |
BeliefanX
force-pushed
the
beliefanx/context-compression-threshold-tokens
branch
from
May 29, 2026 08:35
9670c61 to
daef20c
Compare
BeliefanX
force-pushed
the
beliefanx/context-compression-threshold-tokens
branch
from
June 6, 2026 14:36
daef20c to
43be3cc
Compare
BeliefanX
force-pushed
the
beliefanx/context-compression-threshold-tokens
branch
from
June 14, 2026 08:01
43be3cc to
d5c34c2
Compare
Contributor
|
Thanks for isolating the requested absolute-threshold behavior and for covering model-switch and fallback restoration. Problems
Suggested changes
Automated hermes-sweeper review. |
Contributor
Author
|
Closing this version after re-review against current main. The permanent absolute-threshold knob is not a confirmed product requirement, and this branch's raw-context path no longer fits the effective-input/output-reservation safety model. If a concrete need appears, it should return as a smaller current-main change with the required cache invalidation and documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compression.threshold_tokensas an explicit absolute compression threshold override.Implementation
ContextCompressorstores the user/config absolute value inthreshold_tokens_override.Compatibility / review scope
Testing
/Users/fanxuxin/.hermes/hermes-agent/venv/bin/python -m pytest -o 'addopts=' tests/agent/test_context_compressor.py tests/run_agent/test_switch_model_context.py tests/run_agent/test_compression_feasibility.py -q— 116 passedpy_compilefor touched runtime/config/test files — passed