fix(feishu): keep progress messages in topic threads - #17877
Closed
jlcbk wants to merge 1 commit into
Closed
Conversation
Contributor
|
Automated hermes-sweeper review: this PR's requested Feishu topic-thread behavior is already implemented on current main. Evidence:
Thanks for the useful focused fix; the current main implementation covers the same behavior, so this stale conflicting PR can be closed as implemented on main. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #17875.
This keeps Hermes streaming/progress messages inside the original Feishu/Lark topic thread instead of letting the first/intermediate message create a new topic.
Changes:
GatewayStreamConsumerfor Feishu topic-thread requests, so the first streamed/progress send can usemessage.reply;reply_tobut does havemetadata["thread_id"], create the message withreceive_id_type="thread_id"instead ofchat_id;Test Plan
Result:
274 passed, 4 warnings in 8.25s.