fix(wecom): pad aeskey before base64 decode to handle unpadded WeCom keys - #17858
Closed
elephantjohn wants to merge 1 commit into
Closed
fix(wecom): pad aeskey before base64 decode to handle unpadded WeCom keys#17858elephantjohn wants to merge 1 commit into
elephantjohn wants to merge 1 commit into
Conversation
WeCom delivers aeskey as 43-char base64 strings without trailing '=' padding. Calling base64.b64decode() on it directly raises binascii.Error: 'Incorrect padding', causing image/file decryption to fail silently — users see no response when sending images. Fix: append '=' chars to make the length a multiple of 4 before decoding, which is the standard workaround for unpadded base64.
Collaborator
1 similar comment
Collaborator
Contributor
|
This appears to be implemented on current main by the same WeCom AES-key padding fix. Evidence from automated hermes-sweeper review:
Closing this PR as already implemented on main. Thanks for reporting and sending the focused fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WeCom delivers aeskey as 43-char base64 strings without trailing '='
padding. Calling base64.b64decode() on it directly raises
binascii.Error: 'Incorrect padding', causing image/file decryption
to fail silently — users see no response when sending images.
Fix: append '=' chars to make the length a multiple of 4 before
decoding, which is the standard workaround for unpadded base64.
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs