Skip to content

fix(api-server): preserve tool_call_id in conversation_history #17632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yzxuyang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api-server): preserve tool_call_id in conversation_history #17632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions gateway/platforms/api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2406,7 +2406,10 @@ def _text_cb(delta: Optional[str]) -> None:
_openai_error(f"conversation_history[{i}] must have 'role' and 'content' fields"),
status=400,
)
conversation_history.append({"role": str(entry["role"]), "content": str(entry["content"])})
msg_entry = dict(entry)
msg_entry["role"] = str(entry["role"])
msg_entry["content"] = str(entry["content"])
conversation_history.append(msg_entry)
if previous_response_id:
logger.debug("Both conversation_history and previous_response_id provided; using conversation_history")

Expand All @@ -2432,7 +2435,10 @@ def _text_cb(delta: Optional[str]) -> None:
part.get("text", "") for part in content
if isinstance(part, dict) and part.get("type") == "text"
)
conversation_history.append({"role": msg["role"], "content": str(content)})
msg_entry = dict(msg)
msg_entry["role"] = msg["role"]
msg_entry["content"] = str(content)
conversation_history.append(msg_entry)

session_id = body.get("session_id") or stored_session_id or run_id
ephemeral_system_prompt = instructions
Expand Down