fix(ci): stabilize main test failures - #17618
Closed
stephenschoettler wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Likely duplicate of #17166 — same missing re-export of normalize_whatsapp_identifier from gateway.session. |
1 similar comment
Collaborator
|
Likely duplicate of #17166 — same missing re-export of normalize_whatsapp_identifier from gateway.session. |
Address the remaining base test failures blocking the merge train: restore legacy tool-progress env fallback behavior for Slack, make gateway typing-task shutdown cancellation-safe, harden TUI session-create/close race coverage, tolerate MCP test-server compatibility, and update CLI/provider expectations.
Contributor
Author
|
Closing this one. The WhatsApp re-export portion is a duplicate of #17166, and the later CI stabilization changes broadened this beyond one logical change per CONTRIBUTING.md. If any of the CI fixes are still needed, I'll split them into a focused branch/PR from current main instead of keeping them bundled here. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_whatsapp_identifierfromgateway.sessionfor existing callers.Test plan
.venv/bin/python -m pytest -q -o addopts='' --tb=short -n auto $(tr '\n' ' ' < /tmp/pr17618_failed_tests.txt).venv/bin/python -m pytest -q -o addopts='' --tb=short tests/gateway/test_gateway_shutdown.py tests/gateway/test_session_split_brain_11016.py tests/gateway/test_run_progress_topics.py tests/test_tui_gateway_server.py tests/tui_gateway/test_protocol.py.venv/bin/python -m pytest -q -o addopts='' --tb=short -n auto ...focused modified tests....venv/bin/python -m compileall -q agent/anthropic_adapter.py gateway/platforms/base.py gateway/run.py hermes_cli/main.py hermes_cli/web_server.py tools/mcp_tool.py tui_gateway/server.py tests/hermes_cli/test_auth_commands.py tests/test_tui_gateway_server.pygit diff --checkNotes