Skip to content

fix(gateway): add per-platform connect timeout to prevent blocking (#17242) #17383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vominh1919 wants to merge 1 commit into from
Closed

fix(gateway): add per-platform connect timeout to prevent blocking (#17242) #17383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions gateway/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2453,16 +2453,22 @@ async def start(self) -> bool:
adapter.set_session_store(self.session_store)
adapter.set_busy_session_handler(self._handle_active_session_busy_message)

# Try to connect
# Try to connect — wrap in a per-platform timeout so one
# slow/hanging platform cannot block initialization of others
# (e.g., Telegram retrying 8×15s blocks Feishu startup).
logger.info("Connecting to %s...", platform.value)
self._update_platform_runtime_status(
platform.value,
platform_state="connecting",
error_code=None,
error_message=None,
)
_platform_connect_timeout = 90 # seconds — generous for slow networks
try:
success = await adapter.connect()
success = await asyncio.wait_for(
adapter.connect(),
timeout=_platform_connect_timeout,
)
if success:
self.adapters[platform] = adapter
self._sync_voice_mode_state_to_adapter(adapter)
Expand Down Expand Up @@ -2523,6 +2529,26 @@ async def start(self) -> bool:
"attempts": 1,
"next_retry": time.monotonic() + 30,
}
except asyncio.TimeoutError:
logger.error(
"✗ %s connect timed out after %ds",
platform.value, _platform_connect_timeout,
)
await self._safe_adapter_disconnect(adapter, platform)
self._update_platform_runtime_status(
platform.value,
platform_state="retrying",
error_code="TIMEOUT",
error_message=f"connect timed out after {_platform_connect_timeout}s",
)
startup_retryable_errors.append(
f"{platform.value}: connect timed out after {_platform_connect_timeout}s"
)
self._failed_platforms[platform] = {
"config": platform_config,
"attempts": 1,
"next_retry": time.monotonic() + 30,
}
except Exception as e:
logger.error("✗ %s error: %s", platform.value, e)
# Same defensive cleanup path for exceptions — an adapter
Expand Down
Loading