Skip to content

fix(commands): strip hyphens from Slack slash command names #17081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ms-alan wants to merge 1 commit into from
+3 −3
Closed

fix(commands): strip hyphens from Slack slash command names #17081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hermes_cli/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,14 +820,14 @@ def discord_skill_commands_by_category(
# commands per app.
_SLACK_MAX_SLASH_COMMANDS = 50
_SLACK_NAME_LIMIT = 32
_SLACK_INVALID_CHARS = re.compile(r"[^a-z0-9_\-]")
_SLACK_INVALID_CHARS = re.compile(r"[^a-z0-9_]")


def _sanitize_slack_name(raw: str) -> str:
"""Convert a command name to a valid Slack slash command name.

Slack allows lowercase a-z, digits, hyphens, and underscores. Max 32
chars. Uppercase is lowercased; invalid chars are stripped.
Slack allows lowercase a-z, digits, and underscores only (no hyphens).
Max 32 chars. Uppercase is lowercased; invalid chars are stripped.
"""
name = raw.lower()
name = _SLACK_INVALID_CHARS.sub("", name)
Expand Down
Loading