Conversation
Contributor
Collaborator
|
Closing as superseded by #17024. Triage notes (high confidence): Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen. (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Hermes installer (
scripts/install.sh) uses[ -e /dev/tty ]to detect whether a terminal is available and skip the interactive setup wizard in Docker/CI environments. However, in Docker builds,/dev/ttytypically exists as a device node (-ereturns true) but cannot be opened (returnsENXIO: No such device or address), causing the wizard to run and crash.This fix replaces the bare existence check with an actual open attempt:
Changes
scripts/install.sh: Changed/dev/ttycheck from file existence to actual open attempt, matching the behavior already documented in the comment above it.Testing
/dev/ttyin containerized environmentsFixes #16746