fix(session): make SQLite transcript rewrites transactional - #16926
Merged
Merged
Conversation
alt-glitch
added
type/bug
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #16810 onto current main (clean cherry-pick, @ThomassJonax's authorship preserved).
Summary
rewrite_transcript()(used by /retry, /undo, /compress) now replaces SQLite messages in a single transaction, so a failure mid-rewrite can no longer leave the DB half-empty.Changes
hermes_state.py: newSessionDB.replace_messages()— DELETE + reinsert + counter update inside one_execute_write(BEGIN IMMEDIATE / rollback on raise).gateway/session.py:rewrite_transcript()now callsreplace_messages()instead ofclear_messages+ per-messageappend_messageloop.tests/gateway/test_session.py: regression test asserting a failed rewrite preserves the previous DB transcript.scripts/release.py: AUTHOR_MAP entry for @ThomassJonax.Validation
scripts/run_tests.sh tests/gateway/test_session.py -k 'rewrite or reasoning_survives or atomic'→ 4 passed.Closes #16810.