fix: resolve NameError in rl_cli by moving import before usage - #16798
Closed
Kailigithub wants to merge 1 commit into
Closed
Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
Contributor
|
Duplicate of #6732 — same fix (reorder imports in rl_cli.py to move get_hermes_home before first usage). |
Collaborator
|
Thanks for the contribution! This fix is already present on This is an automated hermes-sweeper review. Evidence:
Closing as already implemented on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves a
NameErrorat module import time inrl_cli.py. The functionget_hermes_home()was called on line 32, but its import fromhermes_constantswas not placed until line 63 — causing the module to crash immediately on anyimport rl_cliorpython rl_cli.py.Fix
Moved
from hermes_constants import get_hermes_home, OPENROUTER_BASE_URLto before the first usage at line 32. Removed the now-redundant duplicate import from the Config Loading section.Verification
python3 -c "import rl_cli"now succeeds with no errorsruff check rl_cli.py --select=F821passes with no issues