fix(cli): ignore terminal focus reports - #16780

Closed

blackpilledsoftware-prog wants to merge 1 commit into

NousResearch:mainfrom

blackpilledsoftware-prog:fix/ignore-terminal-focus-reports

blackpilledsoftware-prog commented Apr 28, 2026

Contributor

Summary

Register terminal focus reports (CSI I / CSI O) as prompt_toolkit parser-level ignored sequences
Add an explicit Keys.Ignore binding so the default self-insert path never inserts focus-report bytes into the prompt
Add regression coverage that parses Ghostty/macOS focus navigation sequences before typed text reaches the buffer

Test Plan

python -m pytest tests/cli/test_cli_terminal_shortcuts.py tests/cli/test_cli_terminal_response_sanitizer.py -q -o 'addopts='
python -m py_compile cli.py tests/cli/test_cli_terminal_shortcuts.py

Notes

This fixes prompt corruption seen in Ghostty on macOS when navigating terminal tabs/windows (for example Cmd+Shift+[ / ] or Alt+Tab).


          fix(cli): ignore terminal focus reports

a9b9a85

alt-glitch added type/bug P2 comp/cli labels

teknium1 mentioned this pull request

fix(cli): ignore terminal focus reports (salvage #16780) #34429

Merged

teknium1 closed this in #34429

teknium1 pushed a commit that referenced this pull request


          fix(cli): ignore terminal focus reports (salvage of #16780)

26b83a5

Ghostty/macOS window or tab navigation (Cmd+Shift+[ / ], Alt+Tab,
etc.) can deliver terminal focus reports (CSI I / CSI O) to the
running TUI. prompt_toolkit does not map those sequences by default,
so its parser falls back to literal key presses (ESC, [, I/O) and
inserts `[I` / `[O` into the prompt buffer after the ESC byte is
handled.

Fix: register the two sequences as Keys.Ignore in ANSI_SEQUENCES at
parser level, plus a no-op kb.add(Keys.Ignore) handler so the
default self-insert path never inserts focus-report bytes.

Salvage notes: original PR put the helper in cli.py. Salvaged into
hermes_cli/pt_input_extras.py alongside install_shift_enter_alias /
install_ctrl_enter_alias to match the established pattern for
ANSI_SEQUENCES augmentation. setdefault → in-check so any prior user
registration wins.

Closes #16780

teknium1 added a commit that referenced this pull request


          chore(release): map blackpilledsoftware-prog email to GitHub login

Required by CI author validation after salvaging PR #16780.

KKT-OPT pushed a commit to KKT-OPT/hermes-agent that referenced this pull request


          fix(cli): ignore terminal focus reports (salvage of NousResearch#16780)

4f98e68

Ghostty/macOS window or tab navigation (Cmd+Shift+[ / ], Alt+Tab,
etc.) can deliver terminal focus reports (CSI I / CSI O) to the
running TUI. prompt_toolkit does not map those sequences by default,
so its parser falls back to literal key presses (ESC, [, I/O) and
inserts `[I` / `[O` into the prompt buffer after the ESC byte is
handled.

Fix: register the two sequences as Keys.Ignore in ANSI_SEQUENCES at
parser level, plus a no-op kb.add(Keys.Ignore) handler so the
default self-insert path never inserts focus-report bytes.

Salvage notes: original PR put the helper in cli.py. Salvaged into
hermes_cli/pt_input_extras.py alongside install_shift_enter_alias /
install_ctrl_enter_alias to match the established pattern for
ANSI_SEQUENCES augmentation. setdefault → in-check so any prior user
registration wins.

Closes NousResearch#16780

KKT-OPT pushed a commit to KKT-OPT/hermes-agent that referenced this pull request


          chore(release): map blackpilledsoftware-prog email to GitHub login

bc58840

Required by CI author validation after salvaging PR NousResearch#16780.

alt-glitch pushed a commit that referenced this pull request


          fix(cli): ignore terminal focus reports (salvage of #16780)

c85b45b

Ghostty/macOS window or tab navigation (Cmd+Shift+[ / ], Alt+Tab,
etc.) can deliver terminal focus reports (CSI I / CSI O) to the
running TUI. prompt_toolkit does not map those sequences by default,
so its parser falls back to literal key presses (ESC, [, I/O) and
inserts `[I` / `[O` into the prompt buffer after the ESC byte is
handled.

Fix: register the two sequences as Keys.Ignore in ANSI_SEQUENCES at
parser level, plus a no-op kb.add(Keys.Ignore) handler so the
default self-insert path never inserts focus-report bytes.

Salvage notes: original PR put the helper in cli.py. Salvaged into
hermes_cli/pt_input_extras.py alongside install_shift_enter_alias /
install_ctrl_enter_alias to match the established pattern for
ANSI_SEQUENCES augmentation. setdefault → in-check so any prior user
registration wins.

Closes #16780

alt-glitch pushed a commit that referenced this pull request


          chore(release): map blackpilledsoftware-prog email to GitHub login

8db46d9

Required by CI author validation after salvaging PR #16780.

T02200059 pushed a commit to T02200059/hermes-agent that referenced this pull request


          fix(cli): ignore terminal focus reports (salvage of NousResearch#16780)

acf5a99

Ghostty/macOS window or tab navigation (Cmd+Shift+[ / ], Alt+Tab,
etc.) can deliver terminal focus reports (CSI I / CSI O) to the
running TUI. prompt_toolkit does not map those sequences by default,
so its parser falls back to literal key presses (ESC, [, I/O) and
inserts `[I` / `[O` into the prompt buffer after the ESC byte is
handled.

Fix: register the two sequences as Keys.Ignore in ANSI_SEQUENCES at
parser level, plus a no-op kb.add(Keys.Ignore) handler so the
default self-insert path never inserts focus-report bytes.

Salvage notes: original PR put the helper in cli.py. Salvaged into
hermes_cli/pt_input_extras.py alongside install_shift_enter_alias /
install_ctrl_enter_alias to match the established pattern for
ANSI_SEQUENCES augmentation. setdefault → in-check so any prior user
registration wins.

Closes NousResearch#16780

T02200059 pushed a commit to T02200059/hermes-agent that referenced this pull request


          chore(release): map blackpilledsoftware-prog email to GitHub login

9147d12

Required by CI author validation after salvaging PR NousResearch#16780.

waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request


          fix(cli): ignore terminal focus reports (salvage of NousResearch#16780)

fbd0854

Ghostty/macOS window or tab navigation (Cmd+Shift+[ / ], Alt+Tab,
etc.) can deliver terminal focus reports (CSI I / CSI O) to the
running TUI. prompt_toolkit does not map those sequences by default,
so its parser falls back to literal key presses (ESC, [, I/O) and
inserts `[I` / `[O` into the prompt buffer after the ESC byte is
handled.

Fix: register the two sequences as Keys.Ignore in ANSI_SEQUENCES at
parser level, plus a no-op kb.add(Keys.Ignore) handler so the
default self-insert path never inserts focus-report bytes.

Salvage notes: original PR put the helper in cli.py. Salvaged into
hermes_cli/pt_input_extras.py alongside install_shift_enter_alias /
install_ctrl_enter_alias to match the established pattern for
ANSI_SEQUENCES augmentation. setdefault → in-check so any prior user
registration wins.

Closes NousResearch#16780

waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request


          chore(release): map blackpilledsoftware-prog email to GitHub login

8de253e

Required by CI author validation after salvaging PR NousResearch#16780.

santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request


          fix(cli): ignore terminal focus reports (salvage of NousResearch#16780)

6671c72

Ghostty/macOS window or tab navigation (Cmd+Shift+[ / ], Alt+Tab,
etc.) can deliver terminal focus reports (CSI I / CSI O) to the
running TUI. prompt_toolkit does not map those sequences by default,
so its parser falls back to literal key presses (ESC, [, I/O) and
inserts `[I` / `[O` into the prompt buffer after the ESC byte is
handled.

Fix: register the two sequences as Keys.Ignore in ANSI_SEQUENCES at
parser level, plus a no-op kb.add(Keys.Ignore) handler so the
default self-insert path never inserts focus-report bytes.

Salvage notes: original PR put the helper in cli.py. Salvaged into
hermes_cli/pt_input_extras.py alongside install_shift_enter_alias /
install_ctrl_enter_alias to match the established pattern for
ANSI_SEQUENCES augmentation. setdefault → in-check so any prior user
registration wins.

Closes NousResearch#16780

santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request


          chore(release): map blackpilledsoftware-prog email to GitHub login

768603c

Required by CI author validation after salvaging PR NousResearch#16780.

donbowman pushed a commit to donbowman/hermes-agent that referenced this pull request


          fix(cli): ignore terminal focus reports (salvage of NousResearch#16780)

b3b7758

Ghostty/macOS window or tab navigation (Cmd+Shift+[ / ], Alt+Tab,
etc.) can deliver terminal focus reports (CSI I / CSI O) to the
running TUI. prompt_toolkit does not map those sequences by default,
so its parser falls back to literal key presses (ESC, [, I/O) and
inserts `[I` / `[O` into the prompt buffer after the ESC byte is
handled.

Fix: register the two sequences as Keys.Ignore in ANSI_SEQUENCES at
parser level, plus a no-op kb.add(Keys.Ignore) handler so the
default self-insert path never inserts focus-report bytes.

Salvage notes: original PR put the helper in cli.py. Salvaged into
hermes_cli/pt_input_extras.py alongside install_shift_enter_alias /
install_ctrl_enter_alias to match the established pattern for
ANSI_SEQUENCES augmentation. setdefault → in-check so any prior user
registration wins.

Closes NousResearch#16780

donbowman pushed a commit to donbowman/hermes-agent that referenced this pull request


          chore(release): map blackpilledsoftware-prog email to GitHub login

65a4569

Required by CI author validation after salvaging PR NousResearch#16780.

Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request


          fix(cli): ignore terminal focus reports (salvage of NousResearch#16780)

9a3392c

Ghostty/macOS window or tab navigation (Cmd+Shift+[ / ], Alt+Tab,
etc.) can deliver terminal focus reports (CSI I / CSI O) to the
running TUI. prompt_toolkit does not map those sequences by default,
so its parser falls back to literal key presses (ESC, [, I/O) and
inserts `[I` / `[O` into the prompt buffer after the ESC byte is
handled.

Fix: register the two sequences as Keys.Ignore in ANSI_SEQUENCES at
parser level, plus a no-op kb.add(Keys.Ignore) handler so the
default self-insert path never inserts focus-report bytes.

Salvage notes: original PR put the helper in cli.py. Salvaged into
hermes_cli/pt_input_extras.py alongside install_shift_enter_alias /
install_ctrl_enter_alias to match the established pattern for
ANSI_SEQUENCES augmentation. setdefault → in-check so any prior user
registration wins.

Closes NousResearch#16780

Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request


          chore(release): map blackpilledsoftware-prog email to GitHub login

6e97ace

Required by CI author validation after salvaging PR NousResearch#16780.

leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request


          fix(cli): ignore terminal focus reports (salvage of NousResearch#16780)

3dc5957

Ghostty/macOS window or tab navigation (Cmd+Shift+[ / ], Alt+Tab,
etc.) can deliver terminal focus reports (CSI I / CSI O) to the
running TUI. prompt_toolkit does not map those sequences by default,
so its parser falls back to literal key presses (ESC, [, I/O) and
inserts `[I` / `[O` into the prompt buffer after the ESC byte is
handled.

Fix: register the two sequences as Keys.Ignore in ANSI_SEQUENCES at
parser level, plus a no-op kb.add(Keys.Ignore) handler so the
default self-insert path never inserts focus-report bytes.

Salvage notes: original PR put the helper in cli.py. Salvaged into
hermes_cli/pt_input_extras.py alongside install_shift_enter_alias /
install_ctrl_enter_alias to match the established pattern for
ANSI_SEQUENCES augmentation. setdefault → in-check so any prior user
registration wins.

Closes NousResearch#16780

leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request


          chore(release): map blackpilledsoftware-prog email to GitHub login

472b282

Required by CI author validation after salvaging PR NousResearch#16780.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli P2 type/bug