fix: set temperature=0.0 for DeepSeek models and send reasoning_effor… - #16715
Closed
dominusbelial wants to merge 7 commits into
Closed
fix: set temperature=0.0 for DeepSeek models and send reasoning_effor…#16715dominusbelial wants to merge 7 commits into
dominusbelial wants to merge 7 commits into
Conversation
alt-glitch
added
type/bug
dominusbelial
force-pushed
the
fix/deepseek-v4-pro-agent-params
branch
3 times, most recently
from
May 3, 2026 13:38
06bd3ec to
c097eae
Compare
dominusbelial
force-pushed
the
fix/deepseek-v4-pro-agent-params
branch
2 times, most recently
from
May 15, 2026 04:00
def1437 to
f598b17
Compare
dominusbelial
force-pushed
the
fix/deepseek-v4-pro-agent-params
branch
from
May 18, 2026 16:07
f598b17 to
a9cf742
Compare
…p-level param DeepSeek V4 defaults to temperature=1.0 (too hot for agent/tool-use). Returns 0.0 for deepseek-v4* models only (not older deepseek-chat/coder). Direct DeepSeek API calls were silently dropping reasoning_effort config because _supports_reasoning_extra_body() returns False. Adds DeepSeek handling in build_kwargs() to send reasoning_effort as a top-level parameter and thinking in extra_body when disabled. DeepSeek V4 only accepts 'high' and 'max' — Hermes values mapped: low/medium -> high, xhigh -> max.
dominusbelial
force-pushed
the
fix/deepseek-v4-pro-agent-params
branch
from
May 24, 2026 15:14
a9cf742 to
29a2255
Compare
…dled by DeepSeekProfile.build_api_kwargs_extras
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist — Code:
- [x] I have read the [Contributing Guide]
- [x] My commit follows [Conventional Commits] (yours does: fix: ...)
- [x] I've checked for duplicate [existing PRs] — reference #16448 by zhanglpg which does the reasoning part, our PR adds the temperature fix they missed
- [x] All existing tests pass
- [x] My code is properly formatted
- [x] No unnecessary dependencies added
agent/auxiliary_client.py — _is_deepseek_model, temperature 0.0: OK
agent/transports/chat_completions.py — syntax: OK
116 existing tests pass