Skip to content

test(tui_gateway): assert target_model in resolve_runtime_provider call #16684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
briandevans wants to merge 2 commits into from
Closed

test(tui_gateway): assert target_model in resolve_runtime_provider call #16684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7bd2ef
test(tui_gateway): assert target_model in resolve_runtime_provider call
briandevans Apr 27, 2026
81c2c39
test(tui_gateway): clear HERMES_MODEL env vars so target_model assert…
briandevans Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions tests/tui_gateway/test_make_agent_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,19 @@
from unittest.mock import MagicMock, patch


def test_make_agent_passes_resolved_provider():
def test_make_agent_passes_resolved_provider(monkeypatch):
"""_make_agent forwards provider/base_url/api_key/api_mode from
resolve_runtime_provider to AIAgent."""

# ``_resolve_model()`` consults ``HERMES_MODEL`` /
# ``HERMES_INFERENCE_MODEL`` *before* falling back to the patched
# ``_load_cfg`` value, so a developer running the suite with either
# env var set would see the resolved model — and therefore the
# ``target_model`` kwarg — diverge from the config default this test
# asserts on. Clear them up front so the assertion is hermetic.
monkeypatch.delenv("HERMES_MODEL", raising=False)
monkeypatch.delenv("HERMES_INFERENCE_MODEL", raising=False)

fake_runtime = {
"provider": "anthropic",
"base_url": "https://api.anthropic.com",
Expand Down Expand Up @@ -45,7 +54,9 @@ def test_make_agent_passes_resolved_provider():

_make_agent("sid-1", "key-1")

mock_resolve.assert_called_once_with(requested=None)
mock_resolve.assert_called_once_with(
requested=None, target_model="claude-opus-4-6"
)
Comment on lines +57 to +59

call_kwargs = mock_agent.call_args
assert call_kwargs.kwargs["provider"] == "anthropic"
Expand Down
Loading