Skip to content

fix: repair broken tool_call arguments at the recovery write site #16505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guigui0711 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix: repair broken tool_call arguments at the recovery write site #16505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion run_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11908,8 +11908,18 @@ def _stop_spinner():
self._vprint(f"{self.log_prefix}⚠️ Injecting recovery tool results for invalid JSON...")
self._invalid_json_retries = 0 # Reset for next attempt

# Append the assistant message with its (broken) tool_calls
# Append the assistant message, repairing broken tool_call
# arguments at write time so corrupted JSON never enters

@teknium1 teknium1 Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current main extracted the live run_conversation loop into agent/conversation_loop.py; the active recovery branch is now at agent/conversation_loop.py:4571 (commit 053025238). Salvage this write-site repair there, before the assistant message is appended.

# the persistent message history.
recovery_assistant = self._build_assistant_message(assistant_message, finish_reason)
for tc_dict in recovery_assistant.get("tool_calls") or []:
raw = tc_dict.get("function", {}).get("arguments", "")
try:
json.loads(raw)
except (json.JSONDecodeError, TypeError):
tc_dict["function"]["arguments"] = _repair_tool_call_arguments(
raw, tc_dict.get("function", {}).get("name", "?"),
)
messages.append(recovery_assistant)

# Respond with tool error results for each tool call
Expand Down