Skip to content

fix(windows): improve path normalization, shell execution, and encoding - #16212

Closed
PratikRai0101 wants to merge 2 commits into
NousResearch:mainfrom
PratikRai0101:fix/windows-native-support
Closed

PratikRai0101 wants to merge 2 commits into
NousResearch:mainfrom
PratikRai0101:fix/windows-native-support

Conversation

@PratikRai0101

Copy link
Copy Markdown
Contributor

What does this PR do?

This is a comprehensive fix for Windows native support (Issue #16201). It addresses three core failure points:

  1. Path Normalization: Replaces mixed slashes with platform-native separators.
  2. Terminal Execution: Fixes `exit code 126` for Windows-compatible shell logic.
  3. Encoding: Forces UTF-8 for stdout to prevent charmap codec crashes in Git Bash.

Related Issue

Fixes #16201

Why a Draft?

Opening as a draft to claim the issue while refining cross-shell compatibility (CMD/PowerShell/Git Bash).

Checklist

  • Tested on Windows 10/11
  • Fixed 'charmap' codec error

@teknium1

teknium1 commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks for this — appreciate the work. We're closing the entire cluster of open native-Windows PRs (44 of them spanning installer, terminal routing, file ops, gateway PID handling, encoding, docs, and more) because the surface area needs a designed, consolidated approach rather than piecemeal merges. Cherry-picking individual fixes keeps leaving inconsistencies and we'd rather land Windows support properly, in one coherent pass.\n\nYour PR is catalogued in our internal Windows support plan. When we pick this back up (soon), we'll mine every PR in the cluster for its fix shape and credit all contributors whose work informs the final patch via lines. Watch for the consolidating PR and feel free to chime in with context on the specific failure mode you were hitting.\n\nClosing for now, not as a rejection of the fix — just queueing it for the designed rollout. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Some issues while working with hermes on Windows

3 participants