fix(nix): skip av/faster-whisper build checks on aarch64-darwin - #16080
Closed
jerome-benoit wants to merge 1 commit into
Closed
fix(nix): skip av/faster-whisper build checks on aarch64-darwin#16080jerome-benoit wants to merge 1 commit into
jerome-benoit wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Nix packaging override for python312.pkgs.av on aarch64-darwin to avoid build-time import/test checks that are being SIGKILLed due to a known Nix daemon Mach-O codesigning corruption issue, restoring nix build success for macOS ARM64.
Changes:
- On
aarch64-darwin, disablesdoCheckand clearspythonImportsCheckfor theavprebuilt override. - Adds inline rationale/comment pointing to the upstream Nix daemon issue/PR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alt-glitch
added
type/bug
jerome-benoit
force-pushed
the
fix/darwin-av-codesigning
branch
7 times, most recently
from
April 26, 2026 15:31
df90542 to
1607b40
Compare
jerome-benoit
changed the title
jerome-benoit
force-pushed
the
fix/darwin-av-codesigning
branch
5 times, most recently
from
April 26, 2026 17:54
aa65da9 to
20c692f
Compare
jerome-benoit
changed the title
jerome-benoit
force-pushed
the
fix/darwin-av-codesigning
branch
3 times, most recently
from
April 27, 2026 11:34
742b3c3 to
25de4e3
Compare
The nix daemon's RewritingSink corrupts Mach-O ad-hoc code signatures on ffmpeg-headless multi-output derivation, causing macOS to SIGKILL any process that dlopens the broken dylibs. Disable the failing check phases on av (pythonImportsCheck + pytest) and faster-whisper (pythonImportsCheck, which transitively loads av). Override av and faster-whisper individually to preserve binary cache for unrelated packages. Drop once NixOS/nix#15638 lands. Fixes NousResearch#15776
jerome-benoit
force-pushed
the
fix/darwin-av-codesigning
branch
from
April 27, 2026 11:39
25de4e3 to
839e935
Compare
Contributor
Author
|
Closing — the aarch64-darwin Thank you @alt-glitch for the comprehensive nix refactor! |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disables build check phases that dlopen broken ffmpeg-headless dylibs on aarch64-darwin:
av: disablepythonImportsCheckandpytestCheckPhase(both load ffmpeg dylibs)faster-whisper: disablepythonImportsCheck(transitively imports av; pytest already off upstream)Overrides are targeted per-package to preserve binary cache for unrelated packages.
Related Issue
Fixes #15776
Type of Change
Changes Made
nix/python.nix: introduceavDarwinandfasterWhisperDarwin— overridden nixpkgs packages with build checks disabled. Used asfromformkPrebuiltOverridein theisAarch64Darwinblock.How to Test
nix build .#packages.aarch64-darwin.defaulton macOS ARM64Killed: 9)Checklist
Code
pytest tests/ -qand all tests passDocumentation & Housekeeping
Context
Note: replaces #15777 which was closed due to corrupted git history.