fix(send_message): fix weixin aiohttp timeout and add gateway bridge fallback - #16074
Closed
JianFeiGan wants to merge 1 commit into
Closed
fix(send_message): fix weixin aiohttp timeout and add gateway bridge fallback#16074JianFeiGan wants to merge 1 commit into
JianFeiGan wants to merge 1 commit into
Conversation
Collaborator
Contributor
|
Thanks for surfacing the weixin aiohttp timeout issue — it's real. The gateway-bridge fallback approach here is substantive enough (adds a new cross-process coordination path with assumptions about bridge availability, port discovery, HTTP retry semantics) that it needs a proper design review rather than an in-batch salvage. Closing for now; if you'd like to push this forward, the narrower "escape the aiohttp-needs-a-task context" fix in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When calling
send_messagefrom CLI or cron sessions to Weixin, the following error occurs:This is caused by
aiohttp 3.10+usingasyncio.timeout()internally inClientTimeout, which is incompatible withloop.run_until_complete()execution mode used by the Hermes CLI tool orchestration.Solution
Fix aiohttp timeout: Replace
aiohttp.ClientTimeout(total=30)withasyncio.wait_for(..., timeout=30)wrapping the HTTP request.Add gateway bridge fallback: The
_send_weixinfunction now attempts to send messages through the local Gateway HTTP Bridge first.Impact