fix(browser): allow explicit CDP override without local agent-browser dependency - #16070
Closed
xyiy001 wants to merge 1 commit into
Closed
fix(browser): allow explicit CDP override without local agent-browser dependency#16070xyiy001 wants to merge 1 commit into
xyiy001 wants to merge 1 commit into
Conversation
xyiy001
force-pushed
the
fix/browser-cdp-checkfn
branch
from
April 26, 2026 14:06
7f0ca26 to
7581dca
Compare
Treat explicit CDP override mode as a valid browser backend even when agent-browser is absent, and add a regression test to prevent false-negative availability gating.
xyiy001
force-pushed
the
fix/browser-cdp-checkfn
branch
from
April 26, 2026 14:06
7581dca to
bdc1db5
Compare
alt-glitch
added
type/bug
Contributor
|
Salvaged via #19670 onto current main - your commit authorship was preserved. Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BROWSER_CDP_URL) as a valid browser backend incheck_browser_requirements().agent-browserbinary even when using direct CDP connection.Why
When users connect via explicit CDP endpoint, the local
agent-browserCLI is not required for capability detection. The previous check incorrectly reported browser tools as unavailable, which blocked valid browser workflows.Changes
tools/browser_tool.py:check_browser_requirements()now returns success when CDP override is present.tests/tools/test_browser_homebrew_paths.py:test_cdp_override_does_not_require_agent_browser_cli.Validation
git log main..HEAD --onelinecontains only this task commit.git diff main --statincludes only planned files.python -m pytest tests/tools/test_browser_homebrew_paths.py::TestBrowserRequirements::test_cdp_override_does_not_require_agent_browser_cli -qRelated Issue