feat(discord): add message edit and delete admin actions - #15864
Conversation
|
Thanks for the complete action wiring and focused tests. The Problems
Suggested changes
Automated hermes-sweeper review. |
a3a8bc4 to
1abfc7a
Compare
|
Thanks — updated this against current main. Kept the existing |
|
@teknium1 This is ready for another look when you have a moment — thanks. |
GottZ
left a comment
There was a problem hiding this comment.
This was generated by AI during triage.
Summary
Three PRs address Discord message mutation: #19052 added deletion, #21197 merged that deletion as a salvage, and the current #15864 diff adds the still-missing edit action while preserving the landed deletion behavior.
Related pull requests
- #15864
related— (+113/-2) — merge: The current diff adds edit_message end to end—PATCH implementation, manifest/schema wiring, required-content validation, registry propagation, 403 guidance, configuration documentation, and focused tests—without replacing the deletion behavior already on main. This follows the keep_open review on #15864, including its request to salvage only editing and document both actions. - #19052 [closed]
related— (+31/-2) — superseded duplicate: This closed PR implemented delete_message across the handler, action manifest, validation, 403 guidance, and tests, but its change was subsequently salvaged and merged through #21197; it remains relevant as the original implementation and attribution source. - #21197 [merged]
related— (+32/-2) — merged reference implementation: This merged PR carries essentially the full #19052 deletion diff plus release attribution, establishing delete_message on main and resolving the deletion portion that the earlier version of #15864 overlapped.
Duplicates
#19052 and #21197 contain essentially the same delete_message implementation; #21197 is the merged salvage of #19052.
Suggested consolidation
Merge #15864 for the non-duplicative edit_message capability, consistent with its keep_open review and updated edit-only diff. Keep #19052 closed as superseded by merged #21197; no further duplicate PR needs closing.
Cross-PR triage: Reviewed 3 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 22 kB of PR diffs, 1 kB of issue/PR text, 2 kB of discussion (6 comments), 1 verify verdict. verdicts reflect diff content, not PR titles. Part of an automated triage batch.
1abfc7a to
89f2da9
Compare
|
@teknium1 Updated against current |
Summary
discord_admin.edit_message(channel_id, message_id, content)discord_admin.delete_message(channel_id, message_id)Part of #1559.
Test Plan
python3 -m pytest tests/tools/test_discord_tool.py -q -o addopts=