Fix DeepSeek reasoning_content propagation - #15760
Conversation
|
Hi @alt-glitch! Thanks for linking those. I reviewed #15748 and #15749, and it looks like there might be a boolean logic bug in the #15749 proposed fix for the cross-provider reasoning leak. In #15749, if My PR (#15760) naturally avoids this by evaluating the DeepSeek requirements before the I've tested this end-to-end and it successfully resolves the 400s without leaking! |
|
Whoops, self-correction! I just took a closer look at the code I pushed originally in this PR and realized it was actually suffering from the exact same ordering issue I just criticized #15749 for. In my initial push, I had evaluated I just force-pushed a fix to this PR. Now the logic works as I described above: This completely strips MiniMax's reasoning and safely injects I have confirmed this with test coverage locally. The logic here is now fully water-tight for cross-provider isolation! Thanks for linking the issues and sorry for the initial confusion! |
|
Closing as redundant — the DeepSeek
21 regression tests in |
This PR fixes two issues with DeepSeek reasoning_content. 1. Extracts reasoning_content from model_extra for ZenMux responses. 2. Adds empty string fallback for DeepSeek to non-tool-call messages.