Skip to content

fix: reset _summary_failure_cooldown_until on session reset (#15547) #15681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vominh1919 wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −1
Open

fix: reset _summary_failure_cooldown_until on session reset (#15547) #15681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1d956d
fix: handle _find_all_skills() exceptions in /api/skills endpoint
vominh1919 Apr 25, 2026
183d824
fix: normalize repeat field in update_job() to prevent TypeError
vominh1919 Apr 25, 2026
e3eb380
fix: reset _summary_failure_cooldown_until on session reset
vominh1919 Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions agent/context_compressor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ def on_session_reset(self) -> None:
self._previous_summary = None
self._last_compression_savings_pct = 100.0
self._ineffective_compression_count = 0
self._summary_failure_cooldown_until = 0.0

@teknium1 teknium1 Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exact reset is already on current main as agent/context_compressor.py:739, from commit e2211b268; remove this hunk when splitting the remaining fixes.


def update_model(
self,
Expand Down
11 changes: 11 additions & 0 deletions cron/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,17 @@ def update_job(job_id: str, updates: Dict[str, Any]) -> Optional[Dict[str, Any]]
continue

updated = _apply_skill_fields({**job, **updates})

# Normalize repeat field if present in updates
if "repeat" in updates:
raw_repeat = updated["repeat"]
if isinstance(raw_repeat, (int, float)):
val = int(raw_repeat) if raw_repeat > 0 else None
updated["repeat"] = {"times": val, "completed": 0}
elif isinstance(raw_repeat, dict):
raw_repeat.setdefault("times", None)
raw_repeat.setdefault("completed", 0)

schedule_changed = "schedule" in updates

if "skills" in updates or "skill" in updates:
Expand Down
5 changes: 4 additions & 1 deletion hermes_cli/web_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1900,7 +1900,10 @@ async def get_skills():
from hermes_cli.skills_config import get_disabled_skills
config = load_config()
disabled = get_disabled_skills(config)
skills = _find_all_skills(skip_disabled=True)
try:
skills = _find_all_skills(skip_disabled=True)
except Exception:
skills = []
for s in skills:
s["enabled"] = s["name"] not in disabled
return skills
Expand Down
Loading