feat(tools): recover non-configurable toolsets, split discord tool, wire feishu - #15613
Merged
Conversation
The reverse-mapping loop in _get_platform_tools only checked CONFIGURABLE_TOOLSETS, silently dropping platform-specific toolsets like discord and feishu_doc whose tools were in the composite but had no configurable key. Add a second pass over TOOLSETS that picks up unclaimed toolsets whose tools are present in the resolved composite.
Split the monolithic discord_server tool (14 actions) into two: - discord: core actions (fetch_messages, search_members, create_thread) that are useful for the agent's normal operation. Auto-enabled on the discord platform via the pipeline fix. - discord_admin: server management actions (list channels/roles, pins, role assignment) that require explicit opt-in via hermes tools. Added to CONFIGURABLE_TOOLSETS and _DEFAULT_OFF_TOOLSETS.
The feishu_doc and feishu_drive tools were registered in the tool registry but never added to the hermes-feishu composite toolset. The pipeline fix from the prior commit now recovers them automatically once they are in the composite.
teknium1
force-pushed
the
salvage/pr-15457-tools-fixes
branch
from
April 25, 2026 11:50
60248f8 to
03a195b
Compare
7 tasks
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #15457 by @alt-glitch onto current main.
Summary
Three independent fixes cleaning up tool/toolset wiring from the last 3 weeks:
_get_platform_toolssilently dropped non-configurable toolsets (discord, feishu_doc, feishu_drive) once the user saved viahermes tools. A second-pass recovery loop now adds them back in both code branches. Skip rules prevent noise (composites, plugins, already-claimed tools, other platforms' default-off toolsets).discord_server→discord(fetch_messages, search_members, create_thread) anddiscord_admin(server management; default-off). Shared schema/handler builders, backward-compatget_dynamic_schema()kept.feishu_doc_read+ fourfeishu_drive_*tools into thehermes-feishucomposite (landed in tools/ but never added to the toolset).Credit
Original PR: #15457 by @alt-glitch — all three commits cherry-picked with authorship preserved.
Test plan
tests/hermes_cli/test_tools_config.py tests/tools/test_discord_tool.py tests/test_toolsets.py— 153 passedNote
Tool rename
discord_server→discordis a breaking schema change for any user withdiscord_serverpinned in their platform_toolsets. Unlikely in practice (it's only ~5 days old and always sat underhermes-discordimplicitly), but worth calling out.