Fix DeepSeek reasoning_content echo on fresh tool calls - #15527
Closed
punkcanyang wants to merge 1 commit into
Closed
Fix DeepSeek reasoning_content echo on fresh tool calls#15527punkcanyang wants to merge 1 commit into
punkcanyang wants to merge 1 commit into
Conversation
Collaborator
This was referenced Apr 25, 2026
Closed
Contributor
|
Closing as redundant — the DeepSeek
21 regression tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
reasoning_content=""on fresh assistant tool-call turns for DeepSeek/Kimi-style thinking providers_copy_reasoning_content_for_api_build_assistant_messagefor DeepSeek tool-call replies without explicitreasoning_contentRoot cause:
_build_assistant_message()checked the DeepSeek fallback inside thehasattr(assistant_message, "reasoning_content")block. On fresh tool-call responses where the SDK object didn't expose that attribute at all, the fallback never ran, so the persisted assistant tool-call message was saved withoutreasoning_content. On the next replay, DeepSeek thinking mode rejected the request with HTTP 400:The reasoning_content in the thinking mode must be passed back to the API.What changed:
tool_callsare materialized intomsg_needs_deepseek_tool_reasoning()and_needs_kimi_tool_reasoning()reasoning_contentuntouched when providers return itVerification:
python -m pytest tests/run_agent/test_deepseek_reasoning_content_echo.py -q_build_assistant_message(..., tool_calls=...)produced noreasoning_contentreasoning_content: ""