Skip to content

fix: handle None skills config in skills_config helpers #15501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kailigithub wants to merge 1 commit into from
Closed

fix: handle None skills config in skills_config helpers #15501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions hermes_cli/skills_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,20 @@

def get_disabled_skills(config: dict, platform: Optional[str] = None) -> Set[str]:
"""Return disabled skill names. Platform-specific list falls back to global."""
skills_cfg = config.get("skills", {})
global_disabled = set(skills_cfg.get("disabled", []))
skills_cfg = config.get("skills") or {}
global_disabled = set(skills_cfg.get("disabled") or [])
if platform is None:
return global_disabled
platform_disabled = skills_cfg.get("platform_disabled", {}).get(platform)
platform_disabled = (skills_cfg.get("platform_disabled") or {}).get(platform)
if platform_disabled is None:
return global_disabled
return set(platform_disabled)


def save_disabled_skills(config: dict, disabled: Set[str], platform: Optional[str] = None):
"""Persist disabled skill names to config."""
config.setdefault("skills", {})
if not isinstance(config.get("skills"), dict):
config["skills"] = {}
if platform is None:
config["skills"]["disabled"] = sorted(disabled)
else:
Expand Down