fix(honcho): harden memory-context leak boundaries to user-visible surfaces - #15371
Closed
erosika wants to merge 2 commits into
Closed
fix(honcho): harden memory-context leak boundaries to user-visible surfaces#15371erosika wants to merge 2 commits into
erosika wants to merge 2 commits into
Conversation
Contributor
Author
|
Superseded by #15381 (consolidated). |
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the memory-context-leak boundary fixes from #13672 by @dontcallmejames with original authorship preserved.
Fixes #5719.
The Honcho Context block was leaking into user-visible messages through the vision auto-analysis path and conversation replay. Two commits land the boundary hardening:
503fa1b9strip leaked memory context from commentary (run_agent codex-responses path)e11bbd98harden memory-context leak boundaries (hermes_state replay, honcho sync, run_agent)Scope note: #13672 bundled four commits; the two above are the advertised fix. The other two are adjacent but out-of-scope for this boundary-fix PR:
02f8043d(hermes update: return to local-overrides branch after update) — unrelated, would warrant its own PRc34e7f20(use conclusions query for honcho search context) — separate concern, worth review on its own meritshermes_state.py: +6 -1
plugins/memory/honcho/init.py: +5 -2
run_agent.py: +12 -4
tests: +90
1411/1412 tests pass across honcho_plugin + run_agent + hermes_state (the single failure on
test_inf_stays_string_for_integer_onlyis a preexisting flake on main, unrelated to these changes).