fix(honcho): CLI credential guard accepts self-hosted baseUrl-only configs - #15362
Closed
erosika wants to merge 1 commit into
Closed
fix(honcho): CLI credential guard accepts self-hosted baseUrl-only configs#15362erosika wants to merge 1 commit into
erosika wants to merge 1 commit into
Conversation
_resolve_api_key() only checks for apiKey / HONCHO_API_KEY, so all CLI subcommands (identity --show, status, migrate, etc.) bail with "No API key configured" on self-hosted instances that use baseUrl without an API key. Return "local" when baseUrl or HONCHO_BASE_URL is set, matching the client.py behavior that already handles this case for the SDK. Tested on: macOS, self-hosted Honcho (Docker, localhost:8000).
Contributor
Author
|
Superseded by #15381 (consolidated). |
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts #14881 by @sasha-id (Alexander Yususpov) with original authorship preserved.
hermes honcho statusand other credential-check commands reject self-hosted Honcho configs that have onlybaseUrl/HONCHO_BASE_URLset without an API key. Self-hosters on local no-auth instances can't use the CLI today._resolve_api_key()now returns the sentinel"local"when no key is configured but a base URL is present. The existing client already skips auth for local base URLs; this makes the CLI guard consistent with that behavior.232/232 honcho_plugin tests pass locally.