fix(honcho): default SDK HTTP timeout to 30s to prevent indefinite blocking - #15360
Closed
erosika wants to merge 1 commit into
Closed
fix(honcho): default SDK HTTP timeout to 30s to prevent indefinite blocking#15360erosika wants to merge 1 commit into
erosika wants to merge 1 commit into
Conversation
When no explicit timeout is configured (HonchoClientConfig.timeout, honcho.timeout / requestTimeout, or HONCHO_TIMEOUT), get_honcho_client previously constructed the SDK with no timeout kwarg, letting the underlying httpx client hang indefinitely if the Honcho backend became unreachable mid-request. This is a silent-failure hazard on the post-response path of run_conversation: the memory_manager.sync_all() / queue_prefetch_all() calls fire after the agent has already generated its final reply, so a stalled Honcho request blocks run_conversation from returning. The gateway never logs "response ready" and never delivers the response to the platform (Telegram, etc.), even though the text is already saved to the session file. Repro: unplug the network or block app.honcho.dev mid-turn after the model has produced its final message. Without this change, _run_agent never returns. With it, the call aborts after 30s, run_conversation returns, and the gateway delivers the response (Honcho sync failure is logged and swallowed as before). The default applies only when nothing is configured, so any deployment that has explicitly set timeout / HONCHO_TIMEOUT / honcho.timeout / honcho.requestTimeout keeps its existing value. Self-hosted deployments that genuinely need a longer ceiling can still override via any of those knobs.
Contributor
Author
|
Superseded by #15381 (consolidated). |
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts #13623 by @twozle with original authorship preserved.
The honcho-ai SDK defaults to a short HTTP timeout. Cold starts and slow backends can exceed it, causing the agent to block indefinitely on the post-response Honcho write path and preventing the gateway from delivering already-generated responses.
Adds a 30s default applied when no explicit timeout is configured via
HonchoClientConfig.timeout,honcho.timeout/requestTimeoutin config, orHONCHO_TIMEOUT.228/228 honcho_plugin tests pass locally.
Overlaps with #10372 (make configurable) — this is the simpler fix; #10372 can layer on top if desired.