Conversation
helix4u
marked this pull request as ready for review
April 24, 2026 21:42
Collaborator
|
Thanks for tracking this down — you correctly identified that Removed Appreciate the thorough PR with tests and docs — sorry we're going the other way on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Honors silent busy-input modes for CLI and gateway sessions.
display.busy_input_modewas only effectively supportinginterruptandqueuein the gateway. Any other value, including the dashboard-exposedblockoption and user-configuredignore, fell back tointerrupt, so busy Discord/Telegram sessions could still post "Interrupting current task..." acknowledgements and interrupt the active run.This PR makes
blockandignoreexplicit silent-drop modes for normal busy-session input. Dedicated mid-run controls such as/stop,/status,/approve,/deny,/queue, and/steerstill work.Related open PRs:
Related Issue
Fixes #
Type of Change
Changes Made
gateway/run.py: acceptsinterrupt,queue,block, andignorefrom config/env and silently drops normal busy-session input inblock/ignoremode.cli.py: honorsblockandignorefor busy Enter behavior instead of falling back to interrupt.hermes_cli/web_server.py: exposes all supported busy-input modes in the settings schema.website/docs/user-guide/cli.mdandwebsite/docs/user-guide/messaging/index.md: document the supported modes.How to Test
display.busy_input_mode: ignoreordisplay.busy_input_mode: block./stopand/statusstill work while the agent is running.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
./scripts/run_tests.sh tests/gateway/test_busy_session_ack.py tests/gateway/test_restart_drain.py tests/gateway/test_session_race_guard.py tests/cli/test_cli_init.py -n 4→70 passed./scripts/run_tests.sh tests/ -n 4→135 failed, 15357 passed, 40 skipped, 184 warnings in 304.57s