test(cli): align custom provider probe assertion with api_mode kwarg - #15254
Closed
WadydX wants to merge 1 commit into
Closed
test(cli): align custom provider probe assertion with api_mode kwarg#15254WadydX wants to merge 1 commit into
WadydX wants to merge 1 commit into
Conversation
alt-glitch
added
type/test
Collaborator
Contributor
Author
|
Closing as duplicate/superseded. This fix path was already covered elsewhere and issue #15243 is now resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_api_modelscall signaturetests/hermes_cli/test_custom_provider_model_switch.pyRoot cause
_model_flow_named_custom()now calls:fetch_api_models(api_key, base_url, timeout=8.0, api_mode=api_mode or None)The test
test_saved_model_still_probes_endpointstill expected a call withoutapi_mode, which causes a false failure.Validation
uv run pytest -q -n 0 tests/hermes_cli/test_custom_provider_model_switch.py::TestCustomProviderModelSwitch::test_saved_model_still_probes_endpoint -vvuv run pytest -q -n 0 tests/hermes_cli/test_custom_provider_model_switch.pyuv run pytest -q -n 0 tests/hermes_cli/test_custom_provider_model_switch.py::TestCustomProviderModelSwitch::test_saved_model_still_probes_endpoint tests/hermes_cli/test_plugin_scanner_recursion.py::TestKindField::test_unknown_kind_falls_back_to_standalone tests/hermes_cli/test_provider_config_validation.py::TestNormalizeCustomProviderEntry::test_unknown_keys_logged tests/hermes_cli/test_provider_config_validation.py::TestNormalizeCustomProviderEntry::test_camel_case_warning_logged -vvFixes #15243