Skip to content

test(model-switch): assert fetch_api_models kwargs match current signature (#15243) #15246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
briandevans wants to merge 1 commit into from
Closed

test(model-switch): assert fetch_api_models kwargs match current signature (#15243) #15246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/hermes_cli/test_custom_provider_model_switch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,14 @@ def test_saved_model_still_probes_endpoint(self, config_home):
patch("builtins.print"):
_model_flow_named_custom({}, provider_info)

# fetch_api_models MUST be called even though model was saved
mock_fetch.assert_called_once_with("sk-test", "https://vllm.example.com/v1", timeout=8.0)
# fetch_api_models MUST be called even though model was saved.
# ``api_mode`` was added to the production signature by 647900e8
# ("fix(cli): support model validation for anthropic_messages and
# cloudflare-protected endpoints") — the test fixture has no
# ``api_mode`` entry so ``api_mode or None`` resolves to ``None``.
mock_fetch.assert_called_once_with(
"sk-test", "https://vllm.example.com/v1", timeout=8.0, api_mode=None,
)

def test_can_switch_to_different_model(self, config_home):
"""User selects a different model than the saved one."""
Expand Down
Loading