Skip to content

Fix Feishu group mention config - #15227

Closed
timmyagentic wants to merge 1 commit into
NousResearch:mainfrom
timmyagentic:fix/feishu-group-mention-config
Closed

Fix Feishu group mention config#15227
timmyagentic wants to merge 1 commit into
NousResearch:mainfrom
timmyagentic:fix/feishu-group-mention-config

Conversation

@timmyagentic

Copy link
Copy Markdown

Fixes #15226

Summary

  • Bridge Feishu group reply settings from config.yaml into runtime PlatformConfig.extra.
  • Add require_group_mention support in the Feishu adapter with a secure default of true.
  • Coerce common boolean representations so string values like "false" work as expected.
  • Add regression tests for config bridging and unmentioned group message routing.

Verification

pytest tests/gateway/test_feishu.py tests/gateway/test_config.py -q
218 passed

Notes

This keeps group policy checks in place before accepting unmentioned group messages. Disabling mention requirements only routes messages when the existing sender/chat policy allows them.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery platform/feishu Feishu / Lark adapter area/config Config system, migrations, profiles labels Apr 24, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the focused Feishu regression report and tests. This is already implemented on current main through the later Feishu admission-policy work, so this PR is now redundant. This is an automated hermes-sweeper review.

  • Merged PR feat(feishu): operator-configurable bot admission and mention policy #18208 closed the linked issue Feishu group messages ignore require_group_mention=false from config.yaml #15226 and introduced the supported require_mention policy (d83b41c9e73670396b6b0815913e744023f0b018).
  • plugins/platforms/feishu/adapter.py:1600-1602 resolves the configurable mention setting with a secure default; plugins/platforms/feishu/adapter.py:4270-4282 preserves group-policy checks and only requires a mention when configured.
  • tests/gateway/test_feishu_bot_admission.py:92-111 and :335-343 cover disabled mention gating and admission of an unmentioned group message under an open policy.
  • The adapter was subsequently migrated from the PR's former gateway/platforms/feishu.py location to plugins/platforms/feishu/adapter.py.

@teknium1 teknium1 closed this Jul 12, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feishu group messages ignore require_group_mention=false from config.yaml

3 participants