Skip to content

fix(cli): merge prompt_caching config category into agent - #15222

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/web-config-schema-category-merge
Closed

LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/web-config-schema-category-merge

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Summary

  • merge the standalone prompt_caching schema category into agent
  • remove the last single-field dashboard config category
  • keep the change scoped to web config schema generation only

Why

The shared Tests / test backlog is red on tests/hermes_cli/test_web_server.py::TestBuildSchemaFromConfig::test_no_single_field_categories because prompt_caching is still emitted as its own one-field category.

Verification

  • python3 - <<"PY" ... checked CONFIG_SCHEMA category counts
  • confirmed prompt_caching count is gone and no category has fewer than 2 fields

@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 24, 2026
@teknium1

Copy link
Copy Markdown
Collaborator

Closing as already fixed on main.

Triage notes (high confidence):
The exact one-line change ("prompt_caching": "agent", in CATEGORY_RENAMES) is already on origin/main hermes_cli/web_server.py:362.

If you still see this on the latest version, please reopen with reproduction steps.

(Bulk-closed during a CLI triage sweep.)

@teknium1 teknium1 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants