fix(normalize): lowercase Xiaomi model IDs for case-insensitive config - #15066
Merged
Conversation
Xiaomi's API (api.xiaomimimo.com) requires lowercase model IDs like "mimo-v2.5-pro" but rejects mixed-case names like "MiMo-V2.5-Pro" that users copy from marketing docs or the ProviderEntry description. Add _LOWERCASE_MODEL_PROVIDERS set and apply .lower() to model names for providers in this set (currently just xiaomi) after stripping the provider prefix. This ensures any case variant in config.yaml is normalized before hitting the API. Other providers (minimax, zai, etc.) are NOT affected — their APIs accept mixed case (e.g. MiniMax-M2.7).
kshitijk4poor
force-pushed
the
fix/xiaomi-model-case-insensitive
branch
from
April 24, 2026 10:30
1f7e0a3 to
00a770c
Compare
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Xiaomi's API (
api.xiaomimimo.com) requires lowercase model IDs likemimo-v2.5-probut rejects mixed-case names likeMiMo-V2.5-Pro. Users naturally copy the marketing-style case from docs and the ProviderEntry description (MiMo-V2.5 and V2 models — pro, omni, flash), then hit unrecognized model errors.Problem
normalize_model_for_provider()for thexiaomiprovider (in_MATCHING_PREFIX_STRIP_PROVIDERS) only strips thexiaomi/prefix but does not normalize case. So:mimo-v2.5-promimo-v2.5-proMiMo-V2.5-ProMiMo-V2.5-Proxiaomi/MiMo-V2.5-ProMiMo-V2.5-ProFix
_LOWERCASE_MODEL_PROVIDERSfrozenset (currently justxiaomi) inmodel_normalize.py.lower()after prefix stripping for providers in this setAfter fix
mimo-v2.5-promimo-v2.5-proMiMo-V2.5-Promimo-v2.5-proxiaomi/MiMo-V2.5-Promimo-v2.5-proMIMO-V2.5-PROmimo-v2.5-proTest plan
test_xiaomi_provider.py:_LOWERCASE_MODEL_PROVIDERS ⊆ _MATCHING_PREFIX_STRIP_PROVIDERSFiles changed
hermes_cli/model_normalize.py— add_LOWERCASE_MODEL_PROVIDERS, apply.lower()in the direct-provider normalization path, add docstring exampletests/hermes_cli/test_xiaomi_provider.py— 15 new tests for case-insensitive normalization + invariant + edge cases